Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.x][springbone][center] fix center coordinate conversion #2470

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

ousttrue
Copy link
Contributor

@ousttrue ousttrue commented Oct 22, 2024

fixed #2440

2nd arg is wrong.

// currentTail が center 適用前
// nextTail が center 適用後で処理されるバグ
m_joints[i] = (transform, init, SpringBoneJointState.Make(scene.Center, currentTail: state.CurrentTail, nextTail: nextTail);           

2nd arg is wrong.
SpringBoneJointState.Make(scene.Center, currentTail: state.CurrentTail
@ousttrue ousttrue added bug Something isn't working SpringBone labels Oct 22, 2024
@ousttrue
Copy link
Contributor Author

center の設定されていない Alicia では再現しないことに注意。
vroid は center あるので再現する。

再現手順は center を原点から移動する。
つまり、モデルを原点から移動する。

Copy link

@mojopon mojopon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2440
こちらのissueを参考に不具合の再現、および手元の環境での修正による改善を確認できました。
LGTM!

@ousttrue ousttrue merged commit 675bb7b into vrm-c:master Oct 22, 2024
1 check passed
@ousttrue ousttrue deleted the fix/springbone0x_center branch October 22, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.x][springbone][center] Imported VRM hair and clothes goes to the left no matter the position
2 participants