springbone 初期化の修正。 #2459
Merged
springbone 初期化の修正。 #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Santarh
approved these changes
Oct 11, 2024
| localScale = transform.localScale, | ||
| localToWorldMatrix = transform.localToWorldMatrix, | ||
| worldToLocalMatrix = transform.worldToLocalMatrix | ||
| }).ToArray(), Allocator.Persistent); |
There was a problem hiding this comment.
ほかの NativeArray もそうですが List -> Array -> NativeArray と変遷するとそこそこ大きな GC Alloc になるので、変更が落ち着いたころに最適化したいところですね
There was a problem hiding this comment.
の入力値を作っているところで、verlet の初期位置が原点になってました。
原点から実位置の delta が大きくなるので 2フレーム目で必ずはねるという挙動に。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tail の初期位置が原点から始まって開始時にはねる。
tail の初期化経路が変わったからかもしれない。
#2440
v0.126は関係あるかもしれないが、別件かもしれない。