Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Box sizing inheritance #426

Merged
merged 5 commits into from
Jan 13, 2021
Merged

[Bugfix] Box sizing inheritance #426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
12faeb8
fix reported errors from inherited box-sizing
LJKaski Jan 11, 2021
d5b0011
update snapshots
LJKaski Jan 11, 2021
f7d472f
add box sizing to pseudo elements in resets
LJKaski Jan 12, 2021
8aa4797
update snapshots
LJKaski Jan 12, 2021
0731bcd
update filter input snapshots
LJKaski Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/core/Block/__snapshots__/Block.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@ exports[`calling render with the same component on the same container does not r
white-space: normal;
}

.c0::before,
.c0::after {
box-sizing: border-box;
}

.c1 {
color: hsl(0,0%,16%);
-webkit-letter-spacing: 0;
Expand Down
25 changes: 25 additions & 0 deletions src/core/Breadcrumb/__snapshots__/Breadcrumb.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@ exports[`calling render with the same component on the same container does not r
text-decoration: underline;
}

.c4::before,
.c4::after {
box-sizing: border-box;
}

.c4:hover,
.c4:active,
.c4:focus,
Expand Down Expand Up @@ -54,6 +59,11 @@ exports[`calling render with the same component on the same container does not r
display: list-item;
}

.c3::before,
.c3::after {
box-sizing: border-box;
}

.c0 {
line-height: 1.15;
-ms-text-size-adjust: 100%;
Expand All @@ -75,6 +85,11 @@ exports[`calling render with the same component on the same container does not r
max-width: 100%;
}

.c0::before,
.c0::after {
box-sizing: border-box;
}

.c2 {
line-height: 1.15;
-ms-text-size-adjust: 100%;
Expand All @@ -101,6 +116,11 @@ exports[`calling render with the same component on the same container does not r
padding-left: 40px;
}

.c2::before,
.c2::after {
box-sizing: border-box;
}

.c7 {
line-height: 1.15;
-ms-text-size-adjust: 100%;
Expand All @@ -125,6 +145,11 @@ exports[`calling render with the same component on the same container does not r
white-space: normal;
}

.c7::before,
.c7::after {
box-sizing: border-box;
}

.c6 {
display: inline-block;
vertical-align: baseline;
Expand Down
25 changes: 25 additions & 0 deletions src/core/Button/__snapshots__/Button.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ exports[`Button variant default should match snapshot 1`] = `
height: auto;
}

.c0::before,
.c0::after {
box-sizing: border-box;
}

.c1 {
color: hsl(0,0%,16%);
-webkit-letter-spacing: 0;
Expand Down Expand Up @@ -321,6 +326,11 @@ exports[`Button variant inverted should match snapshot 1`] = `
height: auto;
}

.c0::before,
.c0::after {
box-sizing: border-box;
}

.c1 {
color: hsl(0,0%,16%);
-webkit-letter-spacing: 0;
Expand Down Expand Up @@ -593,6 +603,11 @@ exports[`Button variant secondary should match snapshot 1`] = `
height: auto;
}

.c0::before,
.c0::after {
box-sizing: border-box;
}

.c1 {
color: hsl(0,0%,16%);
-webkit-letter-spacing: 0;
Expand Down Expand Up @@ -865,6 +880,11 @@ exports[`Button variant secondary-noborder should match snapshot 1`] = `
height: auto;
}

.c0::before,
.c0::after {
box-sizing: border-box;
}

.c1 {
color: hsl(0,0%,16%);
-webkit-letter-spacing: 0;
Expand Down Expand Up @@ -1137,6 +1157,11 @@ exports[`Button variant tertiary match snapshot 1`] = `
height: auto;
}

.c0::before,
.c0::after {
box-sizing: border-box;
}

.c1 {
color: hsl(0,0%,16%);
-webkit-letter-spacing: 0;
Expand Down
30 changes: 30 additions & 0 deletions src/core/Chip/__snapshots__/Chip.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ exports[`children should match snapshot 1`] = `
height: auto;
}

.c0::before,
.c0::after {
box-sizing: border-box;
}

.c2 {
line-height: 1.15;
-ms-text-size-adjust: 100%;
Expand All @@ -73,6 +78,11 @@ exports[`children should match snapshot 1`] = `
white-space: normal;
}

.c2::before,
.c2::after {
box-sizing: border-box;
}

.c1 {
color: hsl(0,0%,16%);
-webkit-letter-spacing: 0;
Expand Down Expand Up @@ -237,6 +247,11 @@ exports[`classnames should match snapshot 1`] = `
height: auto;
}

.c0::before,
.c0::after {
box-sizing: border-box;
}

.c2 {
line-height: 1.15;
-ms-text-size-adjust: 100%;
Expand All @@ -261,6 +276,11 @@ exports[`classnames should match snapshot 1`] = `
white-space: normal;
}

.c2::before,
.c2::after {
box-sizing: border-box;
}

.c1 {
color: hsl(0,0%,16%);
-webkit-letter-spacing: 0;
Expand Down Expand Up @@ -421,6 +441,11 @@ exports[`disabled should match snapshot 1`] = `
height: auto;
}

.c0::before,
.c0::after {
box-sizing: border-box;
}

.c2 {
line-height: 1.15;
-ms-text-size-adjust: 100%;
Expand All @@ -445,6 +470,11 @@ exports[`disabled should match snapshot 1`] = `
white-space: normal;
}

.c2::before,
.c2::after {
box-sizing: border-box;
}

.c1 {
color: hsl(0,0%,16%);
-webkit-letter-spacing: 0;
Expand Down
70 changes: 70 additions & 0 deletions src/core/Dropdown/__snapshots__/Dropdown.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ exports[`Basic dropdown should match snapshot 1`] = `
max-width: 100%;
}

.c2::before,
.c2::after {
box-sizing: border-box;
}

.c0 {
line-height: 1.15;
-ms-text-size-adjust: 100%;
Expand All @@ -45,6 +50,11 @@ exports[`Basic dropdown should match snapshot 1`] = `
white-space: normal;
}

.c0::before,
.c0::after {
box-sizing: border-box;
}

.c3 {
line-height: 1.15;
-ms-text-size-adjust: 100%;
Expand All @@ -69,6 +79,11 @@ exports[`Basic dropdown should match snapshot 1`] = `
white-space: normal;
}

.c3::before,
.c3::after {
box-sizing: border-box;
}

.c1 .fi-dropdown_label-p {
margin-bottom: 8px;
-webkit-letter-spacing: 0;
Expand Down Expand Up @@ -237,6 +252,11 @@ exports[`Controlled Dropdown should match snapshot 1`] = `
max-width: 100%;
}

.c2::before,
.c2::after {
box-sizing: border-box;
}

.c0 {
line-height: 1.15;
-ms-text-size-adjust: 100%;
Expand All @@ -261,6 +281,11 @@ exports[`Controlled Dropdown should match snapshot 1`] = `
white-space: normal;
}

.c0::before,
.c0::after {
box-sizing: border-box;
}

.c3 {
line-height: 1.15;
-ms-text-size-adjust: 100%;
Expand All @@ -285,6 +310,11 @@ exports[`Controlled Dropdown should match snapshot 1`] = `
white-space: normal;
}

.c3::before,
.c3::after {
box-sizing: border-box;
}

.c1 .fi-dropdown_label-p {
margin-bottom: 8px;
-webkit-letter-spacing: 0;
Expand Down Expand Up @@ -454,6 +484,11 @@ exports[`Dropdown as action menu should match snapshot 1`] = `
max-width: 100%;
}

.c2::before,
.c2::after {
box-sizing: border-box;
}

.c0 {
line-height: 1.15;
-ms-text-size-adjust: 100%;
Expand All @@ -478,6 +513,11 @@ exports[`Dropdown as action menu should match snapshot 1`] = `
white-space: normal;
}

.c0::before,
.c0::after {
box-sizing: border-box;
}

.c3 {
line-height: 1.15;
-ms-text-size-adjust: 100%;
Expand All @@ -502,6 +542,11 @@ exports[`Dropdown as action menu should match snapshot 1`] = `
white-space: normal;
}

.c3::before,
.c3::after {
box-sizing: border-box;
}

.c1 .fi-dropdown_label-p {
margin-bottom: 8px;
-webkit-letter-spacing: 0;
Expand Down Expand Up @@ -670,6 +715,11 @@ exports[`Dropdown with additional aria-label should match snapshot 1`] = `
max-width: 100%;
}

.c2::before,
.c2::after {
box-sizing: border-box;
}

.c0 {
line-height: 1.15;
-ms-text-size-adjust: 100%;
Expand All @@ -694,6 +744,11 @@ exports[`Dropdown with additional aria-label should match snapshot 1`] = `
white-space: normal;
}

.c0::before,
.c0::after {
box-sizing: border-box;
}

.c3 {
line-height: 1.15;
-ms-text-size-adjust: 100%;
Expand All @@ -718,6 +773,11 @@ exports[`Dropdown with additional aria-label should match snapshot 1`] = `
white-space: normal;
}

.c3::before,
.c3::after {
box-sizing: border-box;
}

.c1 .fi-dropdown_label-p {
margin-bottom: 8px;
-webkit-letter-spacing: 0;
Expand Down Expand Up @@ -886,6 +946,11 @@ exports[`Dropdown with hidden label should match snapshot 1`] = `
max-width: 100%;
}

.c2::before,
.c2::after {
box-sizing: border-box;
}

.c0 {
line-height: 1.15;
-ms-text-size-adjust: 100%;
Expand All @@ -910,6 +975,11 @@ exports[`Dropdown with hidden label should match snapshot 1`] = `
white-space: normal;
}

.c0::before,
.c0::after {
box-sizing: border-box;
}

.c3 {
position: absolute;
-webkit-clip: rect(0 0 0 0);
Expand Down
Loading