[Bugfix] Box sizing inheritance #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about the box-sizing for pseudo elements, especially focus? Should those be handled with this branch as well? EDIT: This seems to be covered now. |
ketsappi
previously approved these changes
Jan 12, 2021
ketsappi
previously approved these changes
Jan 12, 2021
LJKaski
force-pushed
the
bugfix/box-sizing-inheritance
branch
from
1161704 to
0731bcd
Compare
ketsappi
approved these changes
Jan 13, 2021
aappoalander
approved these changes
Jan 13, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a couple of reported issues where global styles caused inherited box-size CSS rules to cause some issues with radiobutton and external link. External link icon size was also wrong. That was fixed in the process.
Motivation and Context
This was a reported bug, which, while it was caused by a global rule in a different project, was easier to fix on our end.
How Has This Been Tested?
Tested in styleguidist in chrome.
Release notes
-External link and RadioButton pseudo elements now have explicitly set box-size.