[Bugfix] Toggle functionality #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ketsappi
force-pushed
the
bugfix/toggle_functionality
branch
from
530132e to
f349348
Compare
Also fixed the functionality, so that it is now possible to toggle it on/off. Also it shouldn't trigger the state change twice anymore.
ketsappi
force-pushed
the
bugfix/toggle_functionality
branch
from
f349348 to
15d19a4
Compare
J-Kallunki
approved these changes
Nov 12, 2019
aappoalander
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the basic functionality issues that Toggle component did have; including structure changes for Toggle's input-version.
This is second PR of the "series" and should be merged after the PR #224 is merged.
Related Issue
Related issue #154
Motivation and Context
Toggle is now usable and it will no longer trigger the state change twice.
How Has This Been Tested?
yarn validate