Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix toggle basic functionality #154

Closed
LJKaski opened this issue Sep 4, 2019 · 1 comment · Fixed by #257
Closed

[Bugfix] Fix toggle basic functionality #154

LJKaski opened this issue Sep 4, 2019 · 1 comment · Fixed by #257
Assignees
Labels
Accessibility bug Something isn't working Important Selected for Development WIP, PR open, To Do, Waiting for Preview, Waiting for testing
Milestone

Comments

@LJKaski
Copy link
Collaborator

LJKaski commented Sep 4, 2019

Can only be toggled on by dragging, cannot be toggled off. State change triggers twice when clicking the toggle in the styleguide.

@LJKaski LJKaski added the bug Something isn't working label Sep 4, 2019
@LJKaski LJKaski changed the title [Bugfix] Toggle not working correctly [Bugfix] Fix toggle basic functionality Sep 4, 2019
@J-Kallunki J-Kallunki self-assigned this Sep 19, 2019
@J-Kallunki J-Kallunki added this to the 1.0.0 milestone Oct 1, 2019
@J-Kallunki
Copy link
Contributor

Should base on this format:

<label for="suomifi-checkbox-id" class=“suomifi-checkbox">
  <input type="checkbox" id="suomifi-checkbox-id" class=“suomifi-checkbox_input" />
  <svg class=“suomifi-checkbox_icon" />
  <span>Label for the checkbox</span>
</label>
.suomifi-checkbox .suomifi-checkbox_input:checked + .suomifi-checkbox_icon {
}
.suomifi-checkbox .suomifi-checkbox_input:focus + .suomifi-checkbox_icon {
}
.suomifi-checkbox .suomifi-checkbox_input {
  position: absolute;
  // SVG-ikonin koko
  width: 1em;
  height: 1em;
  opacity: 0;
}

and use idGenerator()

@J-Kallunki J-Kallunki added Accessibility Selected for Development WIP, PR open, To Do, Waiting for Preview, Waiting for testing labels Oct 9, 2019
@ketsappi ketsappi assigned ketsappi and unassigned J-Kallunki Oct 23, 2019
ketsappi added a commit that referenced this issue Oct 25, 2019
…ementation

This seems to be the problematic place that was mentioned in the issue #154 of triggering twice when toggling. Will be fixed in separate PR
J-Kallunki pushed a commit that referenced this issue Nov 11, 2019
…ementation

This seems to be the problematic place that was mentioned in the issue #154 of triggering twice when toggling. Will be fixed in separate PR
J-Kallunki pushed a commit that referenced this issue Nov 12, 2019
…ementation

This seems to be the problematic place that was mentioned in the issue #154 of triggering twice when toggling. Will be fixed in separate PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility bug Something isn't working Important Selected for Development WIP, PR open, To Do, Waiting for Preview, Waiting for testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants