Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump xml-crypto #1200

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Bump xml-crypto #1200

merged 1 commit into from
Dec 9, 2022

Conversation

benasher44
Copy link
Contributor

This gets the downstream @xmldom/xmldom update to resolve another dependabot alert.

@benasher44
Copy link
Contributor Author

@jsdevel this is done in #1199 as well. Only difference is that now that I'm a committer, CI has already passed here. Will let you decide next steps!

@benasher44 benasher44 mentioned this pull request Oct 17, 2022
Merged
@andradeinf
Copy link

Any plans to have this PR merged? Issue is being raised by npm audit and breaking CI pipeline according to the company rules

@RopoMen
Copy link

RopoMen commented Oct 20, 2022

This xml-encryption update may potentially contain BREAKING CHANGES because

  1. they self update major version
  2. @xmldom/xmldom states that 0.8.x has BREAKING CHANGES https://github.com/xmldom/xmldom/blob/master/CHANGELOG.md#fixed-6

@AdrianHL AdrianHL mentioned this pull request Oct 20, 2022
Closed
@peterjdrb
Copy link

+1

@ellisium
Copy link

still warm topic?

@mohiteng
Copy link

+1

@jsdevel jsdevel merged commit 0c54399 into vpulim:master Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@benasher44 @andradeinf @RopoMen @peterjdrb @ellisium @mohiteng @jsdevel