Upgrade to Formidable 3, Node 14, and audit fix #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benasher44
commented
Aug 3, 2022
| "module": "commonjs", | ||
| "moduleResolution": "nodenext", |
There was a problem hiding this comment.
needed to have import transpiled to import and not back to require
benasher44
commented
Aug 3, 2022
| @@ -1,8 +1,9 @@ | |||
| { | |||
| "compileOnSave": true, | |||
| "compilerOptions": { | |||
| "target": "es3", | |||
| "target": "es2020", | |||
There was a problem hiding this comment.
with node 12 drop, the target can be bumped to ES2020 (based on https://node.green)
jsdevel
requested changes
Aug 17, 2022
benasher44
force-pushed
the
basher/audit-fix
branch
from
4f63d1d
to
7dafcfa
Compare
jsdevel
approved these changes
Aug 21, 2022
|
@benasher44 please get the build to pass |
benasher44
force-pushed
the
basher/audit-fix
branch
from
7dafcfa
to
9500758
Compare
|
Lint issue is fixed! |
|
Hi @jsdevel! I wanted to check in to see if it might be possible to merge and release this 🙏. Thanks for your support and consideration! |
sandrozbinden-axa
pushed a commit
to axa-health/node-soap
that referenced
this pull request
Oct 6, 2022
|
Hi Team, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formidable 2 has a CVE that is flagged as requiring upgrading to Formidable 3. Formidable 3 is ESM only. To easily support this in node-soap without going through the full CommonJS -> ESM migration, we can do a dynamic import to load Formidable 3. This isn't a huge deal in this library, since the one place where Formidable 3 is used is async anyway.
TS didn't support correctly transpiling import calls until somewhat recently, so doing this required upgrading TypeScript. This also drops Node 12 support, which is EOL.
I also ran audit fix to get this library back to 0 audit issues.