Rename Random Circulant Gram to Random Circulant Gram Matrix #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #681 +/- ##
======================================
Coverage 97.7% 97.7%
======================================
Files 166 166
Lines 3250 3250
Branches 795 795
======================================
Hits 3177 3177
Misses 48 48
Partials 25 25 ☔ View full report in Codecov by Sentry. |
purva-thakre
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Thanks @FabienGhd!
This PR looks good to me. Could you please comment in the corresponding issue so that I can assign it to you? It's a Github thing where a non-maintainer doesn't show up in the list of assignees until they comment there.
|
Nice, thank you for your contribution, @FabienGhd ! Hope to see you around here again soon, and thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR fixes #675.
To maintain project consistency, I have appended "matrix" to the relevant file and function names. Additionally, I have updated the associated documentation and tests.
Best,
Fabien