Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename random circulant gram to random circulant gram matrix #675

Closed
vprusso opened this issue Jul 13, 2024 · 0 comments · Fixed by #681
Closed

Rename random circulant gram to random circulant gram matrix #675

vprusso opened this issue Jul 13, 2024 · 0 comments · Fixed by #681
Labels
good first issue Good for newcomers
Milestone

Comments

@vprusso
Copy link
Owner

vprusso commented Jul 13, 2024

In order to maintain consistency with the rest of the functions in this project, we should add the term "matrix" to the end of both the file and the function.

That is, random_circulant_gram.py should be random_circulant_gram_matrix.py (and similarly for the function name). Updating subsequent docs and tests would also need to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant