Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pylint requirement from 3.1.1 to 3.2.0 #584

Merged
merged 6 commits into from
May 15, 2024
Merged

Update pylint requirement from 3.1.1 to 3.2.0 #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5cd261e
Update pylint requirement from 3.1.1 to 3.2.0
dependabot[bot] May 15, 2024
8eefae1
e0606
purva-thakre May 15, 2024
6d37ffb
try to remove useless suppression
purva-thakre May 15, 2024
cf6c244
add non sequence suppression
purva-thakre May 15, 2024
2c14b79
ruff format
purva-thakre May 15, 2024
62a2a9a
false positive
purva-thakre May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ isort = "5.13.2"
myst-parser = "3.0.1"
pep8 = "1.7.1"
ruff = "0.4.4"
pylint = "3.1.1"
pylint = "3.2.0"
pytest = "8.2.0"
pytest-cov = "5.0.0"
coverage = "7.5.1"
Expand Down
2 changes: 1 addition & 1 deletion toqito/channel_ops/tests/test_partial_channel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def test_partial_channel(test_input, expected, sys_arg, dim_arg):
elif sys_arg is not None and dim_arg is not None:
calculated = partial_channel(test_input, depolarizing(2), sys_arg, dim_arg)

assert np.isclose(calculated, expected).all()
assert np.isclose(calculated, expected).all() # pylint: disable=possibly-used-before-assignment


@pytest.mark.parametrize("nested", [1, 2, 3])
Expand Down
4 changes: 2 additions & 2 deletions toqito/matrix_props/sk_norm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ def sk_operator_norm( # pylint: disable=too-many-locals
elif k == 1:
# we can also get decent lower bounds from the SDP results when k=1
# See Theorem 5.2.8 of [2]
roots, _ = scipy.special.roots_jacobi( # pylint: disable=unbalanced-tuple-unpacking
roots, _ = scipy.special.roots_jacobi( # pylint: disable=unpacking-non-sequence
1, dim[1] - 2, 1
)
gs = min(1 - roots)
Expand Down Expand Up @@ -275,7 +275,7 @@ def sk_operator_norm( # pylint: disable=too-many-locals

upper_bound = min(upper_bound, np.real(cvx_optval))

roots, _ = scipy.special.roots_jacobi( # pylint: disable=unbalanced-tuple-unpacking
roots, _ = scipy.special.roots_jacobi( # pylint: disable=unpacking-non-sequence
np.floor(j / 2) + 1, dim[1] - 2, j % 2
)
gs = min(1 - roots)
Expand Down
2 changes: 1 addition & 1 deletion toqito/state_props/is_unextendible_product_basis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def is_unextendible_product_basis(vecs: list[np.ndarray], dims: list[int]) -> tu
# Acquire generator to m-partitions of [0, n-1].
parts_unordered = set_partitions(list(range(num_vecs)), num_parties)

for part_unordered in parts_unordered:
for part_unordered in parts_unordered: # pylint: disable=not-an-iterable
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this line because I think it is a false positive. If this gets fixed in a newer release, we should get a warning about useless suppression.

for part_ordered in permutations(part_unordered):
# Witness vectors.
wit = []
Expand Down
Loading