Update pylint requirement from 3.1.1 to 3.2.0 #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Updates the requirements on [pylint](https://github.com/pylint-dev/pylint) to permit the latest version. - [Release notes](https://github.com/pylint-dev/pylint/releases) - [Commits](pylint-dev/pylint@v3.1.1...v3.2.0) --- updated-dependencies: - dependency-name: pylint dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #584 +/- ##
======================================
Coverage 98.1% 98.1%
======================================
Files 162 162
Lines 3108 3108
Branches 760 760
======================================
Hits 3050 3050
Misses 37 37
Partials 21 21 ☔ View full report in Codecov by Sentry. |
| @@ -116,7 +116,7 @@ def test_partial_channel(test_input, expected, sys_arg, dim_arg): | |||
| elif sys_arg is not None and dim_arg is not None: | |||
| calculated = partial_channel(test_input, depolarizing(2), sys_arg, dim_arg) | |||
|
|
|||
| assert np.isclose(calculated, expected).all() | |||
| assert np.isclose(calculated, expected).all() # pylint: disable=possibly-used-before-assignment | |||
There was a problem hiding this comment.
Made pylint ignore this line because it doesn't see the conditional assignment in the previous lines.
| @@ -91,7 +91,7 @@ def is_unextendible_product_basis(vecs: list[np.ndarray], dims: list[int]) -> tu | |||
| # Acquire generator to m-partitions of [0, n-1]. | |||
| parts_unordered = set_partitions(list(range(num_vecs)), num_parties) | |||
|
|
|||
| for part_unordered in parts_unordered: | |||
| for part_unordered in parts_unordered: # pylint: disable=not-an-iterable | |||
There was a problem hiding this comment.
added this line because I think it is a false positive. If this gets fixed in a newer release, we should get a warning about useless suppression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the requirements on pylint to permit the latest version.
Commits
b738d23Bump pylint to 3.2.0, update changelog040ce17Upgrade the contributors lists743a04d[performance] Check that 'trailing-comma-tuple' is enabled only once (#9620)b4a9535[pre-commit.ci] pre-commit autoupdate (#9621)a4f9b86[pre-commit.ci] pre-commit autoupdate4f0c7acMerge maintenance/3.1.x into main following 3.1.1 release (#9618)0d8ef10Merge maintenance/3.1.x into main following 3.1.1 releasee53fdb6Bump furo from 2024.4.27 to 2024.5.6 (#9617)814bf94Bump actions/checkout from 4.1.4 to 4.1.5 (#9616)fd6790bAdd ignored modules to Astroid module deny list (#9504)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)