Allow empty local and outputs files to keep centralized Splunk happier. #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d by splunk do not necessarily like these defaults. So allow a way to not provide them. Either by setting undef or passing empty (nil) from hiera.
bastelfreak
reviewed
Oct 18, 2018
manifests/forwarder.pp
Outdated
| @@ -112,8 +118,12 @@ | |||
|
|
|||
| # Declare inputs and outputs specific to the forwarder profile | |||
| $tag_resources = { tag => 'splunk_forwarder' } | |||
| create_resources( 'splunkforwarder_input',$forwarder_input, $tag_resources) | |||
| create_resources( 'splunkforwarder_output',$forwarder_output, $tag_resources) | |||
| if $forwarder_input != undef { | |||
There was a problem hiding this comment.
Suggested change
| if $forwarder_input != undef { | |
| if $forwarder_input { |
bastelfreak
reviewed
Oct 18, 2018
manifests/forwarder.pp
Outdated
| if $forwarder_input != undef { | ||
| create_resources( 'splunkforwarder_input',$forwarder_input, $tag_resources) | ||
| } | ||
| if $forwarder_output != undef { |
There was a problem hiding this comment.
Suggested change
| if $forwarder_output != undef { | |
| if $forwarder_output { |
bastelfreak
changed the title
|
Thanks @gregswift ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Splunk environments where the majority of the configuration is handled by splunk do not necessarily like these defaults. So allow a way to not provide them. Either by setting undef or passing empty (nil) from hiera.