Merge pull request #201 from gregswift/let-splunk-handle-it

Allow empty local and outputs files to keep centralized Splunk happier.

manifests/forwarder.pp

@@ -38,6 +38,12 @@
 #   If set to true, will remove any outputs.conf configuration not supplied by
 #   Puppet from the target system. Defaults to false.
 #
+# [*forwarder_output*]
+#   Hash of output configs.  If undefined will not populate the outputs.conf file.
+#
+# [*forwarder_input*]
+#   Hash of input configs.  If undefined will not populate the inputs.conf file.
+#
 # Actions:
 #
 #   Declares parameters to be consumed by other classes in the splunk module.
@@ -112,8 +118,12 @@
 
   # Declare inputs and outputs specific to the forwarder profile
   $tag_resources = { tag => 'splunk_forwarder' }
-  create_resources( 'splunkforwarder_input',$forwarder_input, $tag_resources)
-  create_resources( 'splunkforwarder_output',$forwarder_output, $tag_resources)
+  if $forwarder_input {
+    create_resources( 'splunkforwarder_input',$forwarder_input, $tag_resources)
+  }
+  if $forwarder_output {
+    create_resources( 'splunkforwarder_output',$forwarder_output, $tag_resources)
+  }
   # this is default
   splunkforwarder_web { 'forwarder_splunkd_port':
     section => 'settings',

spec/classes/forwarder_spec.rb

@@ -8,6 +8,18 @@
       context 'with defaults' do
         it { is_expected.to compile.with_all_deps }
       end
+
+      context 'with forwarder_output set to undef' do
+        let(:params) { { 'forwarder_output' => :undef } }
+
+        it { is_expected.to compile.with_all_deps }
+      end
+
+      context 'with forwarder_input set to undef' do
+        let(:params) { { 'forwarder_input' => :undef } }
+
+        it { is_expected.to compile.with_all_deps }
+      end
     end
   end
 end