(#110) Add support for customizing realm.properties

[patcadelina]

Using realm_template, realm.properties could be customized. By default, rundeck/realm.properties.erb is used.

[dandunckelman]

What's the advantage of managing the template yourself vs writing the configuration of the template that's already present?

[liamjbennett]

The reason this sort of pattern appears again and again in modules is mostly due to the fact that the module (this module) does not update the configuration as new versions are released. If we could keep up with the new configuration in rundeck and if we were managing it all as per documentation then this would not be required, however that is unrealistic so it's valid for us to do.

Having said all that. This pattern does actually scale to more than a couple of templates so we need to be careful about it's use.

[patcadelina]

This pull request (along with 109) unhacks our puppet-rundeck module. @liamjbennett can you share some guidelines as to which templates you believe is worthy of landing in master?

[liamjbennett]

realm.properties is already a pretty generic template. What is it that you are trying to add by using your own? Or it it a UX thing?

[jyaworski]

@liamjbennett IMO it's a good idea to be as generic as possible; we can't account for all possibilities of the use of this module.

@patcadelina please rebase.

[liamjbennett]

Ok, will merge this once rebased.

[patcadelina]

Rebased.

[igalic]

@patcadelina thank you very much for this patch!
same as #109: unless you want magic internet points, and want to still change the commit author on this pr so github recognizes it's you i'll merge this as-is;)

[patcadelina]

Yep, please go ahead @igalic.