(#108) Add support for customizing rundeck-config #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patcadelina
changed the title
patcadelina
changed the title
patcadelina
force-pushed
the
rundeck-config-template
branch
from
001d4fc to
d6976ff
Compare
|
@liamjbennett any update? |
|
Hello: Can you rebase? |
|
Now happy for custom templates to be merged. So please rebased this and we'll get it in. |
patcadelina
force-pushed
the
rundeck-config-template
branch
from
d6976ff to
2834f18
Compare
|
Rebased. |
|
@patcadelina thank you very much for this patch! |
|
Please go ahead @igalic. |
igalic
added a commit
that referenced
this pull request
Oct 20, 2015
(#108) Add support for customizing rundeck-config
|
thanks @patcadelina! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are customizations to
rundeck-configthat I would like to do. Using therdeck_config_template, I could specify a template for it. By default, it would userundeck/rundeck-config.erb.PS: My first contribution to puppet-rundeck, please comment on my diff.