Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modern pip can install wheels without wheel installed #483

Merged
merged 1 commit into from
May 24, 2019
Merged

Modern pip can install wheels without wheel installed #483

merged 1 commit into from
May 24, 2019

Conversation

asottile
Copy link
Contributor

Pull Request (PR) description

Modern versions of pip (>=1.5) can install wheels independent of whether the wheel package is installed.

For example:

$ pip list
argparse (1.2.1)
pip (1.5.6)
setuptools (41.0.1)
wsgiref (0.1.2)
$ pip install cfgv
Downloading/unpacking cfgv
  Downloading cfgv-1.6.0-py2.py3-none-any.whl
Downloading/unpacking six (from cfgv)
  Downloading six-1.12.0-py2.py3-none-any.whl
Installing collected packages: cfgv, six
Successfully installed cfgv six
Cleaning up...

This Pull Request (PR) fixes the following issues

Resolves #481

@asottile asottile mentioned this pull request May 21, 2019
Closed
pillarsdotnet
pillarsdotnet suggested changes May 21, 2019
View reviewed changes
manifests/pip.pp Show resolved Hide resolved
@asottile
Copy link
Contributor Author

@Dan33l mind reviewing this one too ?

@pillarsdotnet
Copy link
Contributor

@bastelfreak ? @alexjfisher ?

@alexjfisher alexjfisher added the enhancement New feature or request label May 24, 2019
@alexjfisher
Copy link
Member

@asottile Thanks for the PR!
@pillarsdotnet Thanks for the review!

@alexjfisher alexjfisher merged commit e9dbed0 into voxpupuli:master May 24, 2019
@asottile asottile deleted the pip_can_use_wheels branch May 24, 2019 15:38
@pillarsdotnet pillarsdotnet mentioned this pull request May 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pillarsdotnet pillarsdotnet pillarsdotnet approved these changes

@alexjfisher alexjfisher alexjfisher approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot install pre-commit pip.
3 participants
@asottile @pillarsdotnet @alexjfisher