Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot install pre-commit pip. #481

Closed
pillarsdotnet opened this issue May 21, 2019 · 3 comments · Fixed by #483
Closed

Cannot install pre-commit pip. #481

pillarsdotnet opened this issue May 21, 2019 · 3 comments · Fixed by #483

Comments

@pillarsdotnet
Copy link
Contributor

pillarsdotnet commented May 21, 2019

Using the puppet-python moodule to install the pre-commit pip results in the following command and output:

pip --log /tmp/pip.log install --upgrade --no-binary :all: pre-commit
DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7.
Collecting pre-commit
  Using cached https://files.pythonhosted.org/packages/58/ab/ce9c21f70238d150c3efb14fc6230017b24729cb482815ba65feba8a2ceb/pre_commit-1.16.1.tar.gz
  WARNING: Generating metadata for package pre-commit produced metadata for project name unknown. Fix your #egg=pre-commit fragments.
Installing collected packages: unknown
  Found existing installation: UNKNOWN 0.0.0
    Uninstalling UNKNOWN-0.0.0:
      Successfully uninstalled UNKNOWN-0.0.0
  Running setup.py install for unknown ... done
Successfully installed unknown-0.0.0

Is this normal and expected behavior?

@pillarsdotnet
Copy link
Contributor Author

Cross-posted: pre-commit/pre-commit#1039

@pillarsdotnet
Copy link
Contributor Author

@asottile said:

your setuptools version is too old, either upgrade that or remove --no-binary :all:

Sure enough, after adding the setuptools pip, the /usr/bin/pre-commit binary appeared on the next puppet run.

@pillarsdotnet
Copy link
Contributor Author

pillarsdotnet commented May 21, 2019

@asottile continued:

it also looks like puppet-python is doing the wrong thing here -- it's assuming that if wheel isn't installed that pip can't install from wheels, which is completely wrong :S

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant