Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up arrow alignement and add a default case to params.pp #62

Merged
merged 1 commit into from
Nov 20, 2014
Merged

Clean up arrow alignement and add a default case to params.pp #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions manifests/init.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,10 +183,10 @@
}

file { $basedir:
ensure => 'directory',
owner => $user,
group => $group,
mode => '0755',
ensure => 'directory',
owner => $user,
group => $group,
mode => '0755',
}

vcsrepo { "${basedir}/puppetboard":
Expand Down
1 change: 1 addition & 0 deletions manifests/params.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
$apache_confd = '/etc/httpd/conf.d'
$apache_service = 'httpd'
}
default: { fail("The ${::osfamily} operating system is not supported with the puppetboard module") }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that really necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a styleguide issue

https://docs.puppetlabs.com/guides/style_guide.html#defaults-for-case-statements-and-selectors

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd rather make RedHat's the default case, since it has quite common naming/placing, and remove the fail statement.

but that's my personal preference/opinion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the correct move. If we can't identify an osfamily we should bail instead of assuming.

}

$user = 'puppetboard'
Expand Down