Clean up arrow alignement and add a default case to params.pp #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to comply with puppet-lint
nibalizer
added a commit
that referenced
this pull request
Nov 20, 2014
Clean up arrow alignement and add a default case to params.pp
|
Thanks! |
| @@ -15,6 +15,7 @@ | |||
| $apache_confd = '/etc/httpd/conf.d' | |||
| $apache_service = 'httpd' | |||
| } | |||
| default: { fail("The ${::osfamily} operating system is not supported with the puppetboard module") } | |||
There was a problem hiding this comment.
it's a styleguide issue
https://docs.puppetlabs.com/guides/style_guide.html#defaults-for-case-statements-and-selectors
There was a problem hiding this comment.
i'd rather make RedHat's the default case, since it has quite common naming/placing, and remove the fail statement.
but that's my personal preference/opinion.
There was a problem hiding this comment.
This is the correct move. If we can't identify an osfamily we should bail instead of assuming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up arrow alignement and add a default case to params.pp in order to comply with puppet-lint