Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu exceptions #104

Merged
merged 2 commits into from
Mar 20, 2016
Merged

Ubuntu exceptions #104

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90120d6
Check for ubuntu for apache_confd
dalesit Mar 17, 2016
56fc6db
Merge remote-tracking branch 'origin/master' into ubuntu-exceptions
dalesit Mar 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions manifests/params.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,14 @@

case $::osfamily {
'Debian': {
if $::operatingsystem == ubuntu {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be == "Ubuntu"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yesno… string comparison in puppet are caseinsensitive.

see https://docs.puppetlabs.com/puppet/4.2/reference/lang_expressions.html#string-encoding-and-comparisons

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are using a bare word, then it needs to begin with lowercase.

see https://docs.puppetlabs.com/puppet/4.2/reference/lang_data_string.html#bare-words

so, can be either format, but == Ubuntu would be incorrect

$apache_confd = '/etc/apache2/conf-enabled'
} else {
$apache_confd = '/etc/apache2/conf.d'
}
$apache_service = 'apache2'
}

'RedHat': {
$apache_confd = '/etc/httpd/conf.d'
$apache_service = 'httpd'
Expand Down