-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ubuntu exceptions #104
Ubuntu exceptions #104
Conversation
Hello. Please rebase and squash. |
Ubuntu uses /etc/apache2/conf-enabled for custom config
a38fb54
to
90120d6
Compare
Rebased and squashed |
@@ -8,9 +8,14 @@ | |||
|
|||
case $::osfamily { | |||
'Debian': { | |||
if $::operatingsystem == ubuntu { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be == "Ubuntu"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yesno… string comparison in puppet are caseinsensitive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are using a bare word, then it needs to begin with lowercase.
see https://docs.puppetlabs.com/puppet/4.2/reference/lang_data_string.html#bare-words
so, can be either format, but == Ubuntu
would be incorrect
Since we don't have spec tests.... Is this also compatible with 3.x? I would assume so, but the bare words doc doesn't exist on 3.8 (by the same name). |
It is compatible with 3.x with future parser |
Ubuntu uses /etc/apache2/conf-enabled for custom config. This adds an exception for Ubuntu in the Debian family case