Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retry and proxywrite for debian family OSes #253

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

Dan33l
Copy link
Member

@Dan33l Dan33l commented Jul 18, 2019

Fixes #252

It looks that it is missing retry entry only in template of Debian family OSes. It is already present in others families.

It looks that it is missing proxy_write entry in RedHat and Debian OSes.
Accordingly with proxy_write_maps it looks that it should be present also in CentOS7 at least. But to be preservative, i only added it in Debian family.

@Dan33l
Copy link
Member Author

Dan33l commented Jul 18, 2019

It looks that camptocamp/augeas have dependencies puppetlabs/stdlib (>= 3.2.0 < 6.0.0). But during acceptance puppetlabs/stdlib 6.0.0 is installed and so can not install camptocamp/augeas.

I am surprised that PR #246 had used puppetlabs-stdlib (v5.2.0)
https://travis-ci.org/camptocamp/puppet-postfix/jobs/529839716#L1081

@Dan33l
Copy link
Member Author

Dan33l commented Jul 18, 2019

@mcanevet @raphink can we use puppetlabs/stdlib 6.0.0 with camptocamp/augeas ?

If yes i'll propose a PR to modify camptocamp/augeas metadata.

@raphink
Copy link
Member

raphink commented Jul 18, 2019

Sure version 6.0.0 should work

@Dan33l
Copy link
Member Author

Dan33l commented Jul 18, 2019

stdlib dependency looks to be removed:
voxpupuli/puppet-augeas#73

A new release of the camptocamp/augeas should be enough.

@raphink
Copy link
Member

raphink commented Jul 23, 2019

puppet-augeas 1.8.0 released

@Dan33l
Copy link
Member Author

Dan33l commented Jul 23, 2019

puppet-augeas 1.8.0 released

Nice. I restart the CI with a Close/Open of this PR.

@Dan33l Dan33l closed this Jul 23, 2019
@Dan33l Dan33l reopened this Jul 23, 2019
@raphink
Copy link
Member

raphink commented Jul 23, 2019

(or you could have asked me and I would have restarted the build 😉 )

@Dan33l
Copy link
Member Author

Dan33l commented Jul 23, 2019

(or you could have asked me and I would have restarted the build wink )

I didn't want to disturb you. This way I was autonomous.

The PR should be ready for a review

@raphink raphink merged commit 6e6c6c9 into voxpupuli:master Jul 26, 2019
@Dan33l
Copy link
Member Author

Dan33l commented Jul 26, 2019

thank you

@Dan33l Dan33l deleted the add-retry-entry branch July 26, 2019 07:51
@kenyon
Copy link
Member

kenyon commented Jul 29, 2019

This actually fixes #204.

@raphink raphink added the enhancement New feature or request label Jan 23, 2020
@bzed bzed mentioned this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qmgr warning: connect to transport private/retry
3 participants