Fix ultralytics extract track IDs

[swheaton]

What changes are proposed in this pull request?

This PR broke ultralytics models when track ID isn't present. Though I don't know what that even is TBH.

How is this patch tested? If it is not, please explain why.

Notably, there are no automated tests. I'm not going to add them now.

import fiftyone as fo
import fiftyone.zoo as foz
import fiftyone.utils.huggingface as fouh
dataset = fouh.load_from_hub(
    "Voxel51/VisDrone2019-DET",
    max_samples=25,
    overwrite=True
    )
model = foz.load_zoo_model(
    "yolov8l-coco-torch",
    device="cuda"
    )
dataset.apply_model(model, label_field="predictions")

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

• No. You can skip the rest of this section.
• Yes. Give a description of this change to be included in the release
  notes for FiftyOne users.

Fix ultralytics models without track ID

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of non-tracking cases, ensuring the system returns appropriate values based on the number of boxes detected.

[coderabbitai]

Walkthrough

The changes involve a modification to the _extract_track_ids function in the fiftyone/utils/ultralytics.py file. The update simplifies how the function generates a list of None values when tracking is not enabled, aligning the length of this list with the size of the confidence tensor. The overall functionality for returning track IDs remains unchanged.

Changes

File	Change Summary
fiftyone/utils/ultralytics.py	Simplified the generation of None values in _extract_track_ids based on result.boxes.conf.size(0).

Poem

In the code, a change was made,
A simple tweak, no need to fade.
With clearer lines and fewer woes,
The rabbit hops where logic flows! 🐇✨
Let's celebrate with joyful cheer,
For clearer code brings us all near!

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e21f1ba and d63f9dc.

Files selected for processing (1)

• fiftyone/utils/ultralytics.py (1 hunks)

Files skipped from review due to trivial changes (1)

• fiftyone/utils/ultralytics.py

[kaixi-wang]

had the same fix but you got it first lol