Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes surname handling for RDNSequence #46

Merged
merged 2 commits into from
Mar 1, 2022
Merged

fixes surname handling for RDNSequence #46

merged 2 commits into from
Mar 1, 2022

Commits on Mar 1, 2022

  1. fixes surname handling for RDNSequence 

    surname used incosistent casing (:surName vs :surname) which led to
an error when providing a string with "SN=Doe" to RDNSequence.new for example.

Changes
- consistently use lowercase for the surname atom in RDNSequence.new_attr/1
- adds testcase to validate that a RDN Sequence with a provided "SN"
  returns without error in RDNSequenceTest
    @tofferoma
    tofferoma committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    8833a28 View commit details
    Browse the repository at this point in the history

  2. improves testcase for RDNSequence surname 

    uses more meaningful and instructive values

Co-authored-by: Bram Verburg <[email protected]>
    @tofferoma @voltone
    tofferoma and voltone committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    5650956 View commit details
    Browse the repository at this point in the history