fixes surname handling for RDNSequence #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surname used incosistent casing (:surName vs :surname) which led to an error when providing a string with "SN=Doe" to RDNSequence.new for example. Changes - consistently use lowercase for the surname atom in RDNSequence.new_attr/1 - adds testcase to validate that a RDN Sequence with a provided "SN" returns without error in RDNSequenceTest
voltone
requested changes
Mar 1, 2022
uses more meaningful and instructive values Co-authored-by: Bram Verburg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
surname used incosistent casing (:surName vs :surname) which led to
an error when providing a string with "SN=Doe" to RDNSequence.new for example.
Changes
returns without error in RDNSequenceTest