Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include full path to log file in error output #395

Merged
merged 1 commit into from
May 1, 2019
Merged

Include full path to log file in error output #395

merged 1 commit into from
May 1, 2019

Conversation

charlespierce
Copy link
Contributor

Closes #358
Closes #387

Include the full path to the log file in the error output, not just the file name.

rwjblue
rwjblue approved these changes May 1, 2019
View reviewed changes
Copy link
Contributor

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@charlespierce charlespierce merged commit 11c1187 into volta-cli:master May 1, 2019
@charlespierce charlespierce deleted the full_log_path branch May 1, 2019 19:34
@chriskrycho chriskrycho mentioned this pull request May 1, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskrycho chriskrycho chriskrycho approved these changes

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error message should include full path to log file Improve the error message with invalid package.json
3 participants
@charlespierce @rwjblue @chriskrycho