Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message should include full path to log file #387

Closed
rwjblue opened this issue Apr 29, 2019 · 0 comments · Fixed by #395
Closed

Error message should include full path to log file #387

rwjblue opened this issue Apr 29, 2019 · 0 comments · Fixed by #395

Comments

@rwjblue
Copy link
Contributor

rwjblue commented Apr 29, 2019

Currently, when an error occurs we give general info in the console and suggest folks to look in the generated log file for more details. Overall, this is really awesome, unfortunately the message only includes the name of the file created and does not give enough info to find the file.

❯ ember s -p 0
Notion error: Could not read package info for dependencies.

Please ensure that all dependencies have been installed.
Error details written to: notion-error-2019-04-29_11_02_40.413.log

Where is notion-error-2019-04-29_11_02_40.413.log?!?

I'd suggest we update the message to something akin to:

Notion error: Could not read package info for dependencies.

Please ensure that all dependencies have been installed.
Error details written to: ~/.notion/log/notion-error-2019-04-29_11_02_40.413.log

This makes it clear where the file is, and even makes the path "clickable" in some terminals (e.g. iTerm2).

P.S - The error messages are significantly better in 0.3.0, thanks to everyone who has worked on them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant