Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] First pass at fish shell support #171

Closed
wants to merge 2 commits into from

Conversation

scalvert
Copy link
Contributor

@scalvert scalvert commented Oct 19, 2018

Adding fish shell support to notion (#152)

TODO:

  • Adding a backend (fish.rs) to crates/notion-core/src/shell/, with a type Fish that implements Shell
  • Adding a bootup script (notion.fish) to shell/unix/, with a wrapper function notion to get installed at console boot time
  • Edit install.sh.in to include installing notion.fish to ~/.config/fish/functions

@scalvert
Copy link
Contributor Author

@dherman any tips on tests for this?

@dherman
Copy link
Collaborator

dherman commented Oct 19, 2018

@scalvert Good question. @mikrostew may have thoughts on this.

This is super exciting—thanks for working on it!

@dherman
Copy link
Collaborator

dherman commented Oct 19, 2018

@scalvert Also, a heads up, I'm thinking about refactoring the directory layout so that we don't clutter the .notion directory with scripts for every shell we support. I'll comment with a link to the issue when it's filed. But don't let that block you here. That'll just be a minor refactor.

@scalvert
Copy link
Contributor Author

Sounds good. I'm happy to move whenever.

@dherman
Copy link
Collaborator

dherman commented Oct 19, 2018

@scalvert I filed issue #177 for the shell directory (and #179 is a sort of unified view of the updated directory layout). It's not implemented yet and I probably won't tackle it until after I finish #148 so it may not end up affecting this PR.

@scalvert
Copy link
Contributor Author

okie dokie

@mikrostew
Copy link
Contributor

@stefanpenner
Copy link
Contributor

stefanpenner commented Jan 9, 2019

until this lands a quick hack to use notion:

set -g fish_user_paths  $HOME/.notion/bin $fish_user_paths

function notion
 $HOME/.notion/notion $argv
end

@chriskrycho chriskrycho mentioned this pull request Feb 9, 2019
@scalvert scalvert deleted the fish-support branch August 11, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants