Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fish support #152

Closed
3 tasks
dherman opened this issue Sep 18, 2018 · 1 comment · Fixed by #266
Closed
3 tasks

fish support #152

dherman opened this issue Sep 18, 2018 · 1 comment · Fixed by #266
Labels
enhancement linux mac

Comments

@dherman
Copy link
Collaborator

dherman commented Sep 18, 2018

Lots of devs use the fish shell (hi @stefanpenner, hi @scalvert!). We should support it!

This will require:

  • Adding a backend (fish.rs) to crates/notion-core/src/shell/, with a type Fish that implements Shell
  • Adding a bootup script (load.fish) to shell/unix/, with a wrapper function notion to get installed at console boot time
  • Adding an installer (install.fish) to dev/unix/

That last task is probably blocked on #151.
@dherman dherman mentioned this issue Sep 18, 2018
Closed
8 tasks
@scalvert scalvert mentioned this issue Oct 19, 2018
Closed
3 tasks
@stefanpenner
Copy link
Contributor

💯

@chriskrycho chriskrycho mentioned this issue Feb 9, 2019
Merged
@ghost ghost mentioned this issue Feb 27, 2019
Closed
@andrewplummer andrewplummer mentioned this issue Jan 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement linux mac
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add fish support 🐟
2 participants
@stefanpenner @dherman