Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick for release-1.10] Optimize bind event update logic #3628

Merged
merged 1 commit into from
Jul 27, 2024
Merged

[cherry-pick for release-1.10] Optimize bind event update logic #3628

merged 1 commit into from
Jul 27, 2024

Conversation

wangyang0616
Copy link
Member

cherry pick from #3622

  1. Optimize the processing logic of Volcano bind interface, and uniformly handle event events and condition updates in the cache Bind interface.
  2. The Bind interface in Binder only handles binding actions and does not involve event updates. It is more convenient to rewrite this capability when other projects reference the Volcano framework for Bind redevelopment.
  3. Optimize error and processing logic.

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 27, 2024
@lowang-bh
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 27, 2024
william-wang
william-wang approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2024
@volcano-sh-bot volcano-sh-bot merged commit a7aeb99 into volcano-sh:release-1.10 Jul 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@william-wang william-wang william-wang approved these changes

@lowang-bh lowang-bh Awaiting requested review from lowang-bh

@shinytang6 shinytang6 Awaiting requested review from shinytang6

Assignees

@william-wang william-wang

@lowang-bh lowang-bh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wangyang0616 @lowang-bh @volcano-sh-bot @william-wang