Optimize bind event update logic #3622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wangyang0616
commented
Jul 25, 2024
•
wangyang0616
commented
- Optimize the processing logic of Volcano bind interface, and uniformly handle event events and condition updates in the cache Bind interface.
- The Bind interface in Binder only handles binding actions and does not involve event updates. It is more convenient to rewrite this capability when other projects reference the Volcano framework for Bind redevelopment.
- Optimize error and processing logic.
volcano-sh-bot
added
the
size/M
wangyang0616
force-pushed
the
bugfix_binder_event
branch
5 times, most recently
from
9e3f974
to
2bbb1dd
Compare
|
/lgtm |
| @@ -99,7 +99,7 @@ type VolumeBinder interface { | |||
|
|
|||
| // Binder interface for binding task and hostname | |||
| type Binder interface { | |||
| Bind(kubeClient kubernetes.Interface, tasks []*api.TaskInfo) ([]*api.TaskInfo, []error) | |||
There was a problem hiding this comment.
@wangyang0616 Do we have to change the interface? I am afraid of the compatibility.
Is there any better way to solve this problem?
There was a problem hiding this comment.
This interface was first broken in https://github.com/volcano-sh/volcano/pull/3547/files.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Signed-off-by: wangyang <[email protected]>
wangyang0616
force-pushed
the
bugfix_binder_event
branch
from
2bbb1dd
to
4864b1b
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.