Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary API update and re-enqueue action #3514

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Avoid unnecessary API update and re-enqueue action #3514

merged 4 commits into from
Jun 20, 2024

Conversation

wangyysde
Copy link
Contributor

@wangyysde wangyysde commented Jun 5, 2024 •
edited
Loading

fix issue #3490

ref: #3502

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 5, 2024
@lowang-bh
Copy link
Member

please rename the PR's title with some meaningful text.

@wangyysde wangyysde changed the title fix issue 3490 Avoid unnecessary API update and re-enqueue action Jun 6, 2024
@wangyysde
Copy link
Contributor Author

please rename the PR's title with some meaningful text.

done

@Monokaix
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
william-wang
william-wang approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2024
@volcano-sh-bot volcano-sh-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2024
@wangyysde
fix issue 3490
fabe916 
Signed-off-by: wangyysde <[email protected]>

fix issue 3490

Signed-off-by: wangyysde <[email protected]>

fix issue_3490

Signed-off-by: wangyysde <[email protected]>
@wangyysde
avoid unnecessary API update and re-enqueue action
63f2fc7 
Signed-off-by: wangyysde <[email protected]>
@wangyysde
avoid unnecessary API update and re-enqueue action
a47b7ec 
Signed-off-by: wangyysde <[email protected]>
@volcano-sh-bot volcano-sh-bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 14, 2024
@wangyysde
Copy link
Contributor Author

/retest

@volcano-sh-bot
Copy link
Contributor

@wangyysde: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lowang-bh
Copy link
Member

/retest

please check the last comment @wangyysde

@wangyysde
Copy link
Contributor Author

@lowang-bh Hi, could you set retest to this PR? I found the following message in E2E test log:
is forbidden: unable to create new content in namespace c800v8rb because it is being terminated", Reason:"Forbidden", Details:(*v1.StatusDetails)(0xc000bc1d40), Code:403}

@lowang-bh
Copy link
Member

@lowang-bh Hi, could you set retest to this PR?

You can close it and reopen, it will trigger ci.

@wangyysde wangyysde closed this Jun 19, 2024
@wangyysde wangyysde reopened this Jun 19, 2024
@googs1025
Copy link
Member

@lowang-bh Hi, could you set retest to this PR? I found the following message in E2E test log: is forbidden: unable to create new content in namespace c800v8rb because it is being terminated", Reason:"Forbidden", Details:(*v1.StatusDetails)(0xc000bc1d40), Code:403}

another way:
git commit --amend -s --no-edit and push again

@wangyysde
Copy link
Contributor Author

@googs1025 ok. thks

william-wang
william-wang approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2024
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot merged commit 7a83757 into volcano-sh:master Jun 20, 2024
24 of 25 checks passed
@Monokaix Monokaix mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lowang-bh lowang-bh lowang-bh left review comments

@Monokaix Monokaix Monokaix left review comments

@william-wang william-wang william-wang approved these changes

@hwdef hwdef Awaiting requested review from hwdef

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

Assignees

@william-wang william-wang

@Monokaix Monokaix

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wangyysde @lowang-bh @Monokaix @volcano-sh-bot @googs1025 @william-wang