Avoid unnecessary API update and re-enqueue action

[Monokaix]

What would you like to be added:

• Currently, when update a resource, volcano haven't compare them before update, which leads to unnecessary update to API server.
• Volcano controller use workqueue to process resources like queue，job, we should check whether a resource exists when processing it to avoid invalid processing and retrying.

Why is this needed:

Lower API server pressure
Avoid unnecessary enent process and enhance performance

[Monokaix]

Here are some codes need to be modified：

1. Check whether newJob and original job are deep equal, update job only when it changed

   volcano/pkg/controllers/job/job_controller_actions.go

   Line 473 in 70a483b

   newJob, err := cc.vcClient.BatchV1alpha1().Jobs(job.Namespace).UpdateStatus(context.TODO(), job, metav1.UpdateOptions{})

2. Skip retry and return nil if err is NotFoundErr

   volcano/pkg/controllers/garbagecollector/garbagecollector.go

   Line 236 in 70a483b

   return gc.vcClient.BatchV1alpha1().Jobs(fresh.Namespace).Delete(context.TODO(), fresh.Name, options)

3. Check whether it's NotFoundErr

   volcano/pkg/controllers/job/job_controller_actions.go

   Line 140 in 70a483b

   if err != nil {

[Monokaix]

/good-first-issue

[volcano-sh-bot]

@Monokaix:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wangyysde]

/assign
I want to try this.

[Monokaix]

/assign I want to try this.

Thanks and welcome!

[wangyysde]

@Monokaix

volcano/pkg/controllers/garbagecollector/garbagecollector.go

Line 217 in 70a483b

if errors.IsNotFound(err) {

Here is skipped retry and returned nil if err is NotFoundErr, is right?

[Monokaix]

@Monokaix

volcano/pkg/controllers/garbagecollector/garbagecollector.go

Line 217 in 70a483b

if errors.IsNotFound(err) {

Here is skipped retry and returned nil if err is NotFoundErr, is right?

It's right here.

[Monokaix]

/close

[volcano-sh-bot]

@Monokaix: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lowang-bh]

Here line307 also need to do comapre and then update:

volcano/pkg/controllers/job/job_controller_actions.go

Lines 299 to 312 in 2e673bc

	if !syncTask {
	if updateStatus != nil {
	if updateStatus(&job.Status) {
	job.Status.State.LastTransitionTime = metav1.Now()
	jobCondition = newCondition(job.Status.State.Phase, &job.Status.State.LastTransitionTime)
	job.Status.Conditions = append(job.Status.Conditions, jobCondition)
	}
	}
	newJob, err := cc.vcClient.BatchV1alpha1().Jobs(job.Namespace).UpdateStatus(context.TODO(), job, metav1.UpdateOptions{})
	if err != nil {
	klog.Errorf("Failed to update status of Job %v/%v: %v",
	job.Namespace, job.Name, err)
	return err
	}