Update NominatedNodeName for pipelined task #3498
Conversation
volcano-sh-bot
added
the
size/M
|
This pr can be part of solution for feature record the norminated node for pod and consider it first in next cycle #3491 |
bibibox
force-pushed
the
update_nominatedNodename
branch
from
bc16b4f
to
ea192f1
Compare
yes, there may be some overlap, and this pr is mainly to solve this issue #3499 |
| klog.V(3).Infof("Updating pod condition for %s/%s to (%s==%s)", pod.Namespace, pod.Name, condition.Type, condition.Status) | ||
| } | ||
|
|
||
| if updateNomiNode { |
There was a problem hiding this comment.
Better add a comment here to explain why this is added？
| @@ -669,19 +669,19 @@ func (ji *JobInfo) TaskSchedulingReason(tid TaskID) (reason string, msg string) | |||
| case Allocated: | |||
| // Pod is schedulable | |||
| msg = fmt.Sprintf("Pod %s/%s can possibly be assigned to %s", taskInfo.Namespace, taskInfo.Name, ctx.NodeName) | |||
| return PodReasonSchedulable, msg | |||
| return PodReasonSchedulable, msg, "" | |||
There was a problem hiding this comment.
Allocated is also a unschedulable case, we should also check whether nominatedNode should be needed, maybe we can refer to kube -scheduler to deep dive.
There was a problem hiding this comment.
the autoscaler will check both condition status and reason whether a pod is unschedulable or not:
so Allocated will not be thought as unschedulable case for autoscaler
Signed-off-by: Wenbo Zhang <[email protected]>
bibibox
force-pushed
the
update_nominatedNodename
branch
from
ea192f1
to
875da0c
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
To fix issue #3499