Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record the norminated node for pod and consider it first in next cycle #3491

Open
lowang-bh opened this issue May 24, 2024 · 10 comments
Open
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@lowang-bh
Copy link
Member

lowang-bh commented May 24, 2024

The norminated node is the node a pipelined task assigned to.

In those cases a task may be pipelined to a norminated node:

  • node has terminating pod and resource is in releasing state, its pod can be pipelined to this node in allocate action
  • the task has evicted other pod on that node and is suitable on that node, its pod will be pipelined to that node in preempt/reclaim action

What would you like to be added:

  1. record the pipelined node for a task which has evicted other task and suitable on that node
  2. check this node is suitable for this task in next scheduling cycle firstly, if predicating returns success, just assign this task to it
  3. if a task has a norminating node, it does not need to do eviction in preempt/reclaim.

Why is this needed:

In the preempt/reclaim actions, task that can not be allocated in allocate action will try to evict other task and then pipeline to the proper node. And we can record it so that we can consider it firstly in the next scheduling cycle, to save time spent on predicating.

@lowang-bh lowang-bh added the kind/feature Categorizes issue or PR as related to a new feature. label May 24, 2024
@lowang-bh lowang-bh changed the title record the norminated node(which is pipelined node in volcano) for pod and consider it first in next cycle record the norminated node for pod and consider it first in next cycle May 24, 2024
@Monokaix
Copy link
Member

So how to do that? just reduce availabel node nums to predict the nominated node?

@lowang-bh
Copy link
Member Author

/good-first-issue

@volcano-sh-bot
Copy link
Contributor

@lowang-bh:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@volcano-sh-bot volcano-sh-bot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 6, 2024
@muskan2622
Copy link

/assign

@JesseStutler
Copy link
Contributor

@muskan2622 Hi, do you still work on this? Could you assign to me? I'm interested to figure out it.

@lowang-bh
Copy link
Member Author

@muskan2622 Hi, do you still work on this? Could you assign to me? I'm interested to figure out it.

I think you can go on.

@muskan2622
Copy link

muskan2622 commented Sep 10, 2024 via email

@muskan2622 muskan2622 removed their assignment Sep 16, 2024
@JesseStutler
Copy link
Contributor

@muskan2622 Hi, you still work on this? But why did you remove the assignment?

@muskan2622
Copy link

I thought it is merged.

@muskan2622
Copy link

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants