-
Notifications
You must be signed in to change notification settings - Fork 971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix calculations of podgroup min resource #3057
Conversation
5406ac3
to
7942a33
Compare
/assign @wangyang0616 @hwdef @Yikun @Thor-wl @william-wang Hi, all guys, would you please have a look at this pr and let us discuss the remaining case (jobMinAvailable < sumup(taskMinAvailable)), eg, jobMinAvailable=2, totalTaskMinAvailable=3, we should sum up at most 2 or 3 member's resource as the job's min resource? I have an idea is to validate the jobMinAvailable and taskTotalMinAvailable. Now there is only validations about jobMinAvailable vs totalReplicas. But there is also another thing need to be noted: task is allocated from high priorith to low priority in allocate action, utill all jobMinAvaiable tasks allocated, then it is ready to commit. volcano/pkg/scheduler/api/job_info.go Lines 758 to 763 in 8d8b691
|
trigger CI |
9e7a2a2
to
4c226b9
Compare
/assign @k82cn @kevin-wangzefeng |
/assign @Monokaix |
Hi,please resolve code conflict. |
4c226b9
to
d63c39c
Compare
d63c39c
to
0116f47
Compare
0116f47
to
e92c897
Compare
/lgtm |
Signed-off-by: lowang_bh <[email protected]>
Signed-off-by: lowang-bh <[email protected]>
…ailable < totalTask's Signed-off-by: lowang-bh <[email protected]>
e92c897
to
431cddb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
commit 1: refact jobinfo's calculation to a function.
commit 2: fix cal podgroup min resource and add testcase. relative design docs: docs about job's min resource #2945
commit 3: when jobMinAvailable < totalTask's, keep the origin logic of calculate podgorup minResource: sum up first jobMinAvailable
Fix #2921 also.