Maybe job's min resource need to considering minMember or min avainable number of each role ?

[lowang-bh]

What would you like to be added:

func (ji *JobInfo) GetMinResources() *Resource {
	if ji.PodGroup.Spec.MinResources == nil {
                // a function to sum up minMember's tasks' reqeust resource
		return ji.CalMinResources() 
	}

	return NewResource(*ji.PodGroup.Spec.MinResources)
}

Why is this needed:

As elastic resource define in queueAttr, it is some of job's elastic resource, which equals to job.allocated - job.minAvailable.
But when cal the min resource for job, it return empty when ji.PodGroup.Spec.MinResources == nil . This is not corresponding with code in controller:

volcano/pkg/controllers/job/job_controller_actions.go

Line 686 in 31b47aa

MinResources: cc.calcPGMinResources(job),

type queueAttr struct {
    // elastic represents the sum of job's elastic resource, job's elastic = job.allocated - job.minAvailable
    elastic *api.Resource
}

// 2. elastic sums up queue's jobs' elastic resource
attr.elastic.Add(job.GetElasticResources())

// 3.  Here, when MinResources is nil,  shall we calculate it by minMember according to task priority?
// so that it can be corresponde with function at pkg/controllers/job/job_controller_actions.go#L686
// GetMinResources return the min resources of podgroup.
func (ji *JobInfo) GetMinResources() *Resource {
	if ji.PodGroup.Spec.MinResources == nil {
		return EmptyResource()
	}

	return NewResource(*ji.PodGroup.Spec.MinResources)
}

func (ji *JobInfo) GetElasticResources() *Resource {
	if ji.Allocated.LessEqualPartly(ji.GetMinResources(), Zero) {
		return EmptyResource()
	}
	return ji.Allocated.Clone().Sub(ji.GetMinResources())
}

[lowang-bh]

What's more, let admission webhook or controller to calculate the minResource for normal podgroups when it is submit, like what's done in vcjob controller

[lowang-bh]

/assign

refer to PR fix calculations of podgroup min resource #3057 to get podgroup min resource