Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

predicate does not stop if node is not suitable for current pod #3050

Closed
lowang-bh opened this issue Aug 13, 2023 · 2 comments · Fixed by #3051
Closed

predicate does not stop if node is not suitable for current pod #3050

lowang-bh opened this issue Aug 13, 2023 · 2 comments · Fixed by #3051
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@lowang-bh
Copy link
Member

caused by Refactor PredicateFn for allocate and preempt actions #2916
Another issue #3049 is also introduced by it.

What happened:

image

What you expected to happen:

stop predicating if one filter retrun non-success.

How to reproduce it (as minimally and precisely as possible):

The code login is changed when refact.

Anything else we need to know?:

The following issues are relative.
#3049
#2975

Environment:

  • Volcano Version: master branch
  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@lowang-bh lowang-bh added the kind/bug Categorizes issue or PR as related to a bug. label Aug 13, 2023
@lowang-bh
Copy link
Member Author

/assign @wangyang0616

@lowang-bh
Copy link
Member Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants