diffferent value of variable in returned err will cause event message too long

[lowang-bh]

When one schedule cycle finishes, scheduler will sum up the unschedule reason and merge same reson. If there are different value of a variable in scheduler error, the unschedule event message will be too long.

What happened:

volcano/pkg/scheduler/actions/allocate/allocate.go

Lines 100 to 118 in 5302995

	predicateFn := func(task *api.TaskInfo, node *api.NodeInfo) ([]*api.Status, error) {
	// Check for Resource Predicate
	if ok, reason := task.InitResreq.LessEqualWithReason(node.FutureIdle(), api.Zero); !ok {
	return nil, api.NewFitError(task, node, reason)
	}
	var statusSets util.StatusSets
	statusSets, err := ssn.PredicateFn(task, node)
	if err != nil {
	return nil, fmt.Errorf("predicates failed in allocate for task <%s/%s> on node <%s>: %v",
	task.Namespace, task.Name, node.Name, err)
	}
	if statusSets.ContainsUnschedulable() || statusSets.ContainsUnschedulableAndUnresolvable() ||
	statusSets.ContainsErrorSkipOrWait() {
	return nil, fmt.Errorf("predicates failed in allocate for task <%s/%s> on node <%s>, status is not success",
	task.Namespace, task.Name, node.Name)
	}
	return nil, nil
	}

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

• Volcano Version:
• Kubernetes version (use kubectl version):
• Cloud provider or hardware configuration:
• OS (e.g. from /etc/os-release):
• Kernel (e.g. uname -a):
• Install tools:
• Others:

[lowang-bh]

@wangyang0616

[lowang-bh]

Another little issue, extender example has broken.

[Ash-KODES]

hey, I am interested in getting into the volcano project,
Can I look into this ?, I think this will help me to understand some flows of the project.

[lowang-bh]

Of cause, welcome!

[wangyang0616]

Yes, each filter node will execute all configured plugins, and finally summarize the results, which will have a certain performance impact compared to the previous implementation logic.

The current modification is mainly to solve the plugin's predicate compatibility with allocate and preempt functions. If there is a better solution, look forward to communicating with you.

[lowang-bh]

/good-first-issue

[lowang-bh]

/close

[volcano-sh-bot]

@lowang-bh: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.