Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot skips Binder badge comment #995

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

trungleduc
Copy link
Member

Close #994

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb ipyvolume.ipynb multiple_widgets.ipynb query-strings.ipynb
Render
chromium
actual 3591 <- [3600 - 3766 - 4030] -> 4044 3517 <- [3549 - 3694 - 3893] -> 4088 3616 <- [3640 - 3671 - 3765] -> 3861 4457 <- [4492 - 4557 - 4574] -> 4735 2331 <- [2334 - 2345 - 2354] -> 2454 4837 <- [4968 - 5305 - 6093] -> 8037 11817 <- [18004 - 18717 - 19662] -> 21075 14759 <- [14907 - 14948 - 14969] -> 15133 1901 <- [1907 - 1923 - 1935] -> 2206
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2021-10-05 18:47:03.691696685 +0000
+++ /dev/fd/62	2021-10-05 18:47:03.691696685 +0000
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.8.0-1042-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
       "release": "20.04.3 LTS",
-      "serial": "487dcaac68944409a00596acdb9a6fc0",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@trungleduc
Copy link
Member Author

trungleduc commented Oct 5, 2021

This PR needs to be merged for the changes take effect since GHA only considers workflow file on the default branch for workflow_run event.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 473e3a9 into voila-dashboards:main Oct 6, 2021
@jtpio
Copy link
Member

jtpio commented Oct 6, 2021

@meeseeksdev please backport to 0.2.x

meeseeksmachine pushed a commit to meeseeksmachine/voila that referenced this pull request Oct 6, 2021
jtpio added a commit that referenced this pull request Oct 6, 2021
…on-0.2.x

Backport PR #995 on branch 0.2.x (Bot skips Binder badge comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmarks workflow overwrites the Binder badge comment
2 participants