Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks workflow overwrites the Binder badge comment #994

Closed
jtpio opened this issue Oct 5, 2021 · 2 comments · Fixed by #995
Closed

Benchmarks workflow overwrites the Binder badge comment #994

jtpio opened this issue Oct 5, 2021 · 2 comments · Fixed by #995
Labels
bug Something isn't working
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Oct 5, 2021

Description

At the moment the benchmark workflow overwrites the Binder badge comment:

image

Reproduce

Example: #993

Expected behavior

This logic would need to handle other comments that are not benchmark comments:

// Find any comment already made by the bot.
const botComment = comments.find(comment => comment.user.id === 41898282)
if (botComment) {
await github.issues.updateComment({
owner: context.repo.owner,
repo: context.repo.repo,
comment_id: botComment.id,
body: report
})
} else {

Context

Noticed in #993 (comment)

@jtpio jtpio added the bug Something isn't working label Oct 5, 2021
@jtpio jtpio added this to the 0.2.x milestone Oct 5, 2021
@trungleduc
Copy link
Member

Thanks @jtpio for reporting it, I will update the bot.

@jtpio
Copy link
Member Author

jtpio commented Oct 5, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants