Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token management #1005

Closed

Conversation

brichet
Copy link

@brichet brichet commented Oct 20, 2021

Fix #825 by adding an optional token parameter when running Voila.
Token must be filled manually in command line, it is not automatically generated.
The token parameter must be provided in VoilaHandler and VoilaTreeHandler URL, otherwise a 404 error is thrown.

@github-actions
Copy link
Contributor

Binder 👈 Try it on binder (branch brichet/voila/token_management_0.3.0a2)

1 similar comment
@github-actions
Copy link
Contributor

Binder 👈 Try it on binder (branch brichet/voila/token_management_0.3.0a2)

@majidaldo
Copy link

majidaldo commented Oct 30, 2021

wouldn't jupyter be a better place to handle this?

@brichet
Copy link
Author

brichet commented Nov 2, 2021

Jupyter already handles this in each application :

  • NotebookApp.Token for Jupyter Notebook
  • ServerApp.Token for Jupyter Lab

This pull request is basically a copy of what is done in Jupyter to bring the feature to Voilà.

@brichet
Copy link
Author

brichet commented May 3, 2023

Superseded by #1308

@brichet brichet closed this May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Token management or any other secured way to serve a Voilà application
2 participants