Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token management or any other secured way to serve a Voilà application #825

Closed
brichet opened this issue Feb 10, 2021 · 5 comments
Closed

Comments

@brichet
Copy link

brichet commented Feb 10, 2021

Hi,
Maybe I missed some improvements but I didn't find a way to authenticate users before using a Voilà application.
In my case I don't necessarily need a secure authentication but it would be good to be able to use a token (that enough security for my needs).
Is there any reason why this is not implemented ?
There is some commented code about that in app.py with that line above :

# TODO: do we want to have the token?

I made some modifications to add an option --Voila.token=<unicode> to let user add his own token, so if you think this feature can be interesting I can create a PR.
Nicolas

@GregSilverman
Copy link

Same question I had. I do however need secure authentication.

@brichet
Copy link
Author

brichet commented Mar 27, 2021

@GregSilverman you can try https://github.com/brichet/voila/tree/token_management, which enables a token with the option --Voila.token=<unicode>. It is currently not updated to the latest version of the master.

@GregSilverman
Copy link

Cool! Thanks!

@timkpaine
Copy link
Member

#724 can also be used

@brichet
Copy link
Author

brichet commented May 3, 2023

Fixed by #1308

@brichet brichet closed this as completed May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants