Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing react-dom module to Webpack shared scope #67

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Add missing react-dom module to Webpack shared scope #67

merged 1 commit into from
Apr 20, 2023

Conversation

trungleduc
Copy link
Member

References

Issue found while working with a widget requiring the react-dom module.

Code changes

User-facing changes

Backwards-incompatible changes

@trungleduc trungleduc added the enhancement New feature or request label Apr 19, 2023
@github-actions
Copy link
Contributor

lite-badge 👈 Try it on ReadTheDocs

jtpio
jtpio approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 2d3c48b into voila-dashboards:main Apr 20, 2023
@martinRenou
Copy link
Member

It seems we have the same issue in Voila with ipyflex not working because of missing react-dom, will open a PR.

@martinRenou martinRenou mentioned this pull request Apr 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

@martinRenou martinRenou Awaiting requested review from martinRenou

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trungleduc @martinRenou @jtpio