Add missing react-dom module to Webpack shared scope (#67)

voila-dashboards · Apr 20, 2023 · 2d3c48b · 2d3c48b
1 parent 2786aa6
commit 2d3c48b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/voici/package.json b/packages/voici/package.json
@@ -50,7 +50,8 @@
     "@lumino/virtualdom": "^1.11.2",
     "@lumino/widgets": "^1.26.2",
     "@voila-dashboards/voila": "^0.5.0-alpha.3",
-    "react": "^17.0.1"
+    "react": "^17.0.1",
+    "react-dom": "^17.0.1"
   },
   "devDependencies": {
     "@babel/core": "^7.2.2",

diff --git a/packages/voici/src/index.ts b/packages/voici/src/index.ts
@@ -8,12 +8,12 @@
  ****************************************************************************/
 import '@jupyterlab/nbconvert-css/style/index.css';
 
+import 'react-dom';
 import { PageConfig, URLExt } from '@jupyterlab/coreutils';
 import { JupyterLiteServer } from '@jupyterlite/server';
 import { IKernelSpecs } from '@jupyterlite/kernel';
 
 import { VoilaShell } from '@voila-dashboards/voila';
-
 import { VoiciApp } from './app';
 import plugins from './plugins';
 import { loadComponent, createModule, activePlugins } from './utils';