Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Package: ncspot-0.2.0. #23817

Closed
wants to merge 1 commit into from
Closed

New Package: ncspot-0.2.0. #23817

wants to merge 1 commit into from

Conversation

Mia-Rain
Copy link
Contributor

No description provided.

Copy link
Member

@Chocimier Chocimier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Packages should be build and run for a while before submission, unless you had difficulties. If so, they should be described upfront.

srcpkgs/ncspot/files/LICENSE Outdated Show resolved Hide resolved
srcpkgs/ncspot/template Outdated Show resolved Hide resolved
srcpkgs/ncspot/template Outdated Show resolved Hide resolved
srcpkgs/ncspot/template Outdated Show resolved Hide resolved
srcpkgs/ncspot/template Outdated Show resolved Hide resolved
@Mia-Rain Mia-Rain changed the title New Package: ncs-spot-0.2.0. New Package: ncsspot-0.2.0. Jul 25, 2020
@Mia-Rain Mia-Rain changed the title New Package: ncsspot-0.2.0. New Package: ncspot-0.2.0. Jul 25, 2020
@Mia-Rain
Copy link
Contributor Author

Builds on arm based aches fail due to

thread 'main' panicked at '/builddir/ncspot-0.2.0/target/aarch64-unknown-linux-gnu/release/build/ncurses-00645f4d6448e2e2/out/chtype_size failed: Os { code: 8, kind: Other, message: "Exec format error" }', /host/cargo/registry/src/github.com-1ecc6299db9ec823/ncurses-5.99.0/build.rs:106:20

I cannot confirm the cause of this, nor can I figure out how to fix it,
even cloning makedepends and hostmakedepends did not resolve the issue, thus I am restricting the arches

makedepends="${hostmakedepends}"

@fosslinux
Copy link
Contributor

No, the issue here is not restricted archs, it is that the package is nocross (ie, will need some fiddling with qemu-user-static and stuff to generate the offending data). Please change the archs= line to nocross="ncurses exec format error" or something of that nature.

@fosslinux
Copy link
Contributor

Also, conflicts with #23415

@Mia-Rain
Copy link
Contributor Author

Understandable, although, #23415 seems to have a much nicer template, I'm a bit new so I figured it would be, I don't know if I'll close this PR or not yet, but if #23415 got updated for "0.2.0" I most likely would, seeing as "0.2.0" is the stable release for everything other than nixpkgs and DPorts

@Mia-Rain
Copy link
Contributor Author

For now I'll just make the requested edits

srcpkgs/ncspot/template Outdated Show resolved Hide resolved
srcpkgs/ncspot/template Outdated Show resolved Hide resolved
 ncspot: now "nocross"
  Some other requested edits were done
@rien
Copy link
Contributor

rien commented Jul 27, 2020

Hi there! ncspot has different audio backends (alsa, pulse, ...) that's why my PR has the vopt_if statements in them (just like the spotifyd template, which is very similar).

I can update my PR if you'd like. It was ready for review but I guess it disappeared into he backlog :)

@Mia-Rain
Copy link
Contributor Author

Mia-Rain commented Jul 27, 2020

Hey! Yeh, your template is quite nice, I tend to write my templates from the ground up, and leave optional features up to the user to figure out, If you were to update it to 0.2.0 that wouldn't be a bad Idea, sad that it got lost and never got merged, I'd recommend you, re-request review and see what happens from there, if and when you update your PR to 0.2.0 I'll close this PR

@Mia-Rain
Copy link
Contributor Author

Mia-Rain commented Aug 15, 2020

I'm going to close this PR in hopes that #23415 will be merged.

@Mia-Rain Mia-Rain closed this Aug 15, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants