-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package: ncspot-0.2.0 #23415
New package: ncspot-0.2.0 #23415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to make a build_option
for pulseaudio, you can, but leaving it in as a default isn't too much of an issue. You can take a look at spotifyd
's template for how this was done.
You might have to set some environment variable for cross compilation to work properly. We have some of those in common/build-helper/rust.sh
.
Conflicts with #23817 |
Updated to 0.2.0 |
@Chocimier @ericonr this PR is ready for a new review; I've updated ncspot to 0.2.0 and confirmed it builds on my machine. What is the default behavior for the |
After looking at the |
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
This packages ncspot, a ncurses Spotify client.
It is currently built with a pulseaudio backend (default), but it can be configured to use alsa or portaudio. Is there a policy preferring an audio backend? Or should I create two (sub)packages:
ncspot-pulseaudio
andncspot-alsa
?