Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: ncspot-0.2.0 #23415

Closed
wants to merge 1 commit into from
Closed

New package: ncspot-0.2.0 #23415

wants to merge 1 commit into from

Conversation

rien
Copy link
Contributor

@rien rien commented Jul 6, 2020

This packages ncspot, a ncurses Spotify client.

It is currently built with a pulseaudio backend (default), but it can be configured to use alsa or portaudio. Is there a policy preferring an audio backend? Or should I create two (sub)packages: ncspot-pulseaudio and ncspot-alsa?

@rien
Copy link
Contributor Author

rien commented Jul 6, 2020

Copy link
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to make a build_option for pulseaudio, you can, but leaving it in as a default isn't too much of an issue. You can take a look at spotifyd's template for how this was done.

You might have to set some environment variable for cross compilation to work properly. We have some of those in common/build-helper/rust.sh.

srcpkgs/ncspot/template Outdated Show resolved Hide resolved
srcpkgs/ncspot/template Outdated Show resolved Hide resolved
srcpkgs/ncspot/template Outdated Show resolved Hide resolved
@fosslinux
Copy link
Contributor

Conflicts with #23817

@rien
Copy link
Contributor Author

rien commented Jul 27, 2020

Updated to 0.2.0

@rien rien changed the title New package: ncspot-0.1.4 New package: ncspot-0.2.0 Jul 27, 2020
@rien
Copy link
Contributor Author

rien commented Jul 27, 2020

@Chocimier @ericonr this PR is ready for a new review; I've updated ncspot to 0.2.0 and confirmed it builds on my machine.

What is the default behavior for the vopt_if statements? Which options will be enabled in the binary repositories? If none are enabled, then this package is a bit useless (the default configuration will print the raw audio to stdout instead of playing trough pulse or alsa).

@rien
Copy link
Contributor Author

rien commented Jul 27, 2020

After looking at the spotifyd template, I've seen you can specify build_options_default to enable suggested features. I've enabled both alsa and pulse by default (as is the case with spotifyd).

sgn pushed a commit to sgn/void-packages that referenced this pull request Aug 27, 2020
@ericonr ericonr added the new-package This PR adds a new package label Dec 20, 2020
@ram02z ram02z mentioned this pull request Oct 17, 2021
3 tasks
@github-actions
Copy link

Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.

@github-actions github-actions bot added the Stale label Apr 17, 2022
@rien rien closed this Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package This PR adds a new package Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants