Fix bug where VDC storage profile disablement didn't work #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaidotas Bauzys <[email protected]>
Signed-off-by: Vaidotas Bauzys <[email protected]>
Signed-off-by: Vaidotas Bauzys <[email protected]>
vbauzys
requested review from
dataclouder,
Didainius and
lvirbalas
as code owners
vbauzys
requested review from
mikeletux and
adambarreiro
and removed request for
dataclouder
lvirbalas
requested changes
Feb 3, 2022
Signed-off-by: Vaidotas Bauzys <[email protected]>
adambarreiro
approved these changes
Feb 9, 2022
Didainius
approved these changes
Feb 18, 2022
lvirbalas
approved these changes
Feb 22, 2022
mikeletux
approved these changes
Feb 22, 2022
Signed-off-by: Vaidotas Bauzys <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dep: vmware/go-vcloud-director#433
Ref: #754
Fix issue were VDC storage profile disablement value was ignored during serialization (fix is in govcd type changes)