Vdc bug fixes for disabling storage profile and deserializing type.Task on vdc.update #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'master' of github.com:vmware/go-vcloud-director
Merge branch 'master' of github.com:vmware/go-vcloud-director
Merge branch 'master' of github.com:vmware/go-vcloud-director
# Conflicts: # govcd/api.go # govcd/api_vcd_test.go # govcd/openapi_endpoints.go # types/v56/constants.go # types/v56/openapi.go
vbauzys
requested review from
dataclouder,
Didainius and
lvirbalas
as code owners
vbauzys
requested review from
mikeletux and
adambarreiro
and removed request for
dataclouder
vbauzys
changed the title
vbauzys
changed the title
lvirbalas
reviewed
Feb 3, 2022
lvirbalas
approved these changes
Feb 3, 2022
Didainius
approved these changes
Feb 18, 2022
| @@ -0,0 +1,2 @@ | |||
| * Fixes Issue #431 "Wrong order in Task structure" [GH-433] | |||
There was a problem hiding this comment.
IMO we need to mention "convert field types" - so that it is clear why we broke compatibility
adambarreiro
approved these changes
Feb 18, 2022
mikeletux
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref:vmware/terraform-provider-vcd#754
Ref:#431
Fixes Issue "Wrong order in Task structure" for VDC update
Fixes Issue where VDC creation with storage profile
enabled=falsewasn't working